This repository has been archived by the owner on Oct 26, 2022. It is now read-only.
Remove the option during install to copy and customize all roles #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly give the option to add an additional playbook. This won't break existing projects, since the variable that allows changing the provisioning source is still there.
byrond
reviewed
May 12, 2020
| <property name="custom_playbook" value="${default.custom_playbook}" /> | ||
| </else> | ||
| </if> | ||
| <input propertyName="custom_playbook" message="Add a custom Ansible playbook to your project " promptChar="?" validArgs="Y,n" defaultValue="${default.custom_playbook}" /> |
There was a problem hiding this comment.
I always assume the default is in caps, so validArgs="y,N"?
There was a problem hiding this comment.
Oh, never mind! I see that it's case sensitive. Oops!
byrond
approved these changes
May 12, 2020
There was a problem hiding this comment.
I tested this on a new project with and without a custom playbook, as well as a project with roles that were copied and customized (without reinstalling the-vagrant). Everything worked great! I ran the installer on the project with customized roles and saw the expected changes in the Vagrantfile. I assume it's up to the project's developer to revert any unwanted changes (for example, after installation, the customized playbook will not be run).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only give the option to add an additional playbook. This won't break existing projects, since the variable that allows changing the provisioning source is still there.